Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIE2] Alias Analysis using AddrSpace Info #173

Open
wants to merge 2 commits into
base: aie-public
Choose a base branch
from
Open

[AIE2] Alias Analysis using AddrSpace Info #173

wants to merge 2 commits into from

Conversation

krishnamtibrewala
Copy link
Collaborator

@krishnamtibrewala krishnamtibrewala commented Aug 28, 2024 •
edited
Loading

The work is guarded under an option --aie-alias-analysis-addrspace.

Note : There are no QoR gain with this work!!

@andcarminati
Copy link
Collaborator

Hi @krishnamtibrewala, I think that 05ae54e can be moved to another PR.

martien-de-jong
martien-de-jong reviewed Sep 3, 2024
View reviewed changes
llvm/lib/Target/AIE/AIE2.h Outdated Show resolved Hide resolved
llvm/lib/Target/AIE/AIE2AddrSpace.h Outdated Show resolved Hide resolved
@martien-de-jong
Copy link
Collaborator

The work is guarded under an option --aie2-AS-AA.

Does it cause errors in QoR? If so, are they caused by erroneous bank annotations?

@krishnamtibrewala
Copy link
Collaborator Author

The work is guarded under an option --aie2-AS-AA.

Does it cause errors in QoR? If so, are they caused by erroneous bank annotations?

Yes, since it can potential error in QoR due to erroneous bank annotations.

@krishnamtibrewala krishnamtibrewala mentioned this pull request Sep 3, 2024
Merged
@krishnamtibrewala
Copy link
Collaborator Author

Hi @krishnamtibrewala, I think that 05ae54e can be moved to another PR.

have moved the commit to PR #179

@andcarminati
Copy link
Collaborator

As a suggestion, we can have PR just for [AIE2] Refactor address space code. In this way we will keep this PR smaller.

@krishnamtibrewala krishnamtibrewala mentioned this pull request Sep 17, 2024
Merged
@krishnamtibrewala krishnamtibrewala marked this pull request as ready for review October 17, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martien-de-jong martien-de-jong martien-de-jong left review comments

@andcarminati andcarminati andcarminati left review comments

@abhinay-anubola abhinay-anubola Awaiting requested review from abhinay-anubola abhinay-anubola is a code owner

@abnikant abnikant Awaiting requested review from abnikant abnikant is a code owner

@gbossu gbossu Awaiting requested review from gbossu gbossu is a code owner

@khallouh khallouh Awaiting requested review from khallouh khallouh is a code owner

@konstantinschwarz konstantinschwarz Awaiting requested review from konstantinschwarz konstantinschwarz is a code owner

@SagarMaheshwari99 SagarMaheshwari99 Awaiting requested review from SagarMaheshwari99 SagarMaheshwari99 is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishnamtibrewala @andcarminati @martien-de-jong